From 744644fc2d433bdd3f5511f5a09afae675f040f3 Mon Sep 17 00:00:00 2001 From: Camil Staps Date: Fri, 22 May 2015 10:08:25 +0200 Subject: Cleanup & javadoc StorageProviders --- .../org/rssin/android/DefaultStorageProvider.java | 19 +++++++++++++++++-- .../main/java/org/rssin/android/FiltersList.java | 11 +++++------ .../org/rssin/android/InternalStorageProvider.java | 22 ++++++++++++++++++++-- .../android/SharedPreferencesStorageProvider.java | 19 ++++++++++++++++--- .../main/java/org/rssin/android/VolleyFetcher.java | 2 +- .../org/rssin/storage/FilterStorageProvider.java | 3 ++- app/src/main/java/org/rssin/storage/Storable.java | 3 ++- .../java/org/rssin/storage/StorageProvider.java | 3 ++- 8 files changed, 65 insertions(+), 17 deletions(-) (limited to 'app/src/main/java') diff --git a/app/src/main/java/org/rssin/android/DefaultStorageProvider.java b/app/src/main/java/org/rssin/android/DefaultStorageProvider.java index b1d05bf..f47419d 100644 --- a/app/src/main/java/org/rssin/android/DefaultStorageProvider.java +++ b/app/src/main/java/org/rssin/android/DefaultStorageProvider.java @@ -3,13 +3,23 @@ package org.rssin.android; import android.content.Context; /** - * Created by camilstaps on 22-5-15. + * Default Storage Provider + * At the moment, this is merely a wrapper for SharedPreferencesStorageProvider. + * This class enables us to easily change the storage method we use throughout the app. + * + * @author Camil Staps */ -public class DefaultStorageProvider extends SharedPreferencesStorageProvider { +class DefaultStorageProvider extends SharedPreferencesStorageProvider { + protected DefaultStorageProvider(Context context) { super(context); } + /** + * Get a possibly new instance of the StorageProvider + * @param context if there is no instance yet, we use this to build it + * @return + */ public static DefaultStorageProvider getInstance(Context context) { if (instance == null) { instance = new DefaultStorageProvider(context); @@ -17,7 +27,12 @@ public class DefaultStorageProvider extends SharedPreferencesStorageProvider { return (DefaultStorageProvider) instance; } + /** + * Get the saved instance, and return null if it doesn't exist + * @return + */ public static DefaultStorageProvider getInstance() { return (DefaultStorageProvider) instance; } + } diff --git a/app/src/main/java/org/rssin/android/FiltersList.java b/app/src/main/java/org/rssin/android/FiltersList.java index 3cbd907..aa2a92b 100755 --- a/app/src/main/java/org/rssin/android/FiltersList.java +++ b/app/src/main/java/org/rssin/android/FiltersList.java @@ -3,16 +3,15 @@ package org.rssin.android; import android.content.Context; import org.rssin.rssin.Filter; -import org.rssin.storage.FilterStorageProvider; import java.io.IOException; import java.util.List; /** - * A list of filters that can be saved in internal storage + * A list of filters that can be saved using the DefaultStorageProvider * @author Camil Staps */ -public class FiltersList { +class FiltersList { private static FiltersList instance; @@ -20,8 +19,8 @@ public class FiltersList { private final DefaultStorageProvider storageProvider; /** - * Fetch from internal storage - * @param context needed to get to internal storage + * Fetch from storage provider + * @param context needed to get the storageprovider * @throws IOException if data is corrupted, and deserializing fails */ protected FiltersList(Context context) throws IOException { @@ -44,7 +43,7 @@ public class FiltersList { } /** - * Save all filters in internal storage + * Save all filters * @throws Exception if serializing or saving failed */ public synchronized void save() throws Exception { diff --git a/app/src/main/java/org/rssin/android/InternalStorageProvider.java b/app/src/main/java/org/rssin/android/InternalStorageProvider.java index 1d700e1..feff5f0 100644 --- a/app/src/main/java/org/rssin/android/InternalStorageProvider.java +++ b/app/src/main/java/org/rssin/android/InternalStorageProvider.java @@ -19,9 +19,10 @@ import java.util.ArrayList; import java.util.List; /** - * Created by camilstaps on 21-5-15. + * A way to store data in internal storage + * @author Camil Staps */ -public class InternalStorageProvider implements StorageProvider, FilterStorageProvider { +class InternalStorageProvider implements StorageProvider, FilterStorageProvider { protected static final String PREFIX = "storage_", PREFIX_FILTER = "f_", PREFIX_FEEDSORTER = "fs_"; private static InternalStorageProvider instance; @@ -71,10 +72,22 @@ public class InternalStorageProvider implements StorageProvider { List allFilters(); diff --git a/app/src/main/java/org/rssin/storage/Storable.java b/app/src/main/java/org/rssin/storage/Storable.java index feb850a..ef34245 100644 --- a/app/src/main/java/org/rssin/storage/Storable.java +++ b/app/src/main/java/org/rssin/storage/Storable.java @@ -3,7 +3,8 @@ package org.rssin.storage; import java.io.Serializable; /** - * Created by camilstaps on 21-5-15. + * An element which can be stored using a StorageProvider + * @author Camil Staps */ public interface Storable extends Serializable { } diff --git a/app/src/main/java/org/rssin/storage/StorageProvider.java b/app/src/main/java/org/rssin/storage/StorageProvider.java index ba62028..7e382c2 100644 --- a/app/src/main/java/org/rssin/storage/StorageProvider.java +++ b/app/src/main/java/org/rssin/storage/StorageProvider.java @@ -1,7 +1,8 @@ package org.rssin.storage; /** - * Created by camilstaps on 21-5-15. + * A storage provider is able to store and fetch Storables to keys of type K. + * @author Camil Staps */ public interface StorageProvider { /** -- cgit v1.2.3