aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-10-26Merge pull request #318 from gportay/fix-invalid-cpu-placeholderIngo Bürk3-1/+17
print_cpu_usage: fix invalid %cpu placeholder output
2018-10-23Add testcase for invalid %cpu placeholderGaël PORTAY2-0/+16
2018-10-21print_cpu_usage: fix invalid %cpu placeholder outputGaël PORTAY1-1/+1
Currently, the module cpu_usage prints %cpu0 information for the invalid %cpu placeholder (i.e. the cpu number is missing). Consider the following configuration. order += "cpu_usage" cpu_usage { format = "cpu0=%cpu0 cpu1=%cpu1 cpu=%cpu" # missing cpu number -------------------^ } The configuration above produces the output below. $ i3status -c config i3status: trying to auto-detect output_format setting i3status: auto-detected "term" cpu0=-2% cpu1=-49% cpu=-2% cpu0=06% cpu1=02% cpu=06% cpu0=05% cpu1=06% cpu=05% ... The module prints %cpu0 at the third placeholder where it should report an error. This commit fixes this behavior by initializing `number' to -1. If the cpu is missing in %cpu placeholder, the sscanf function does not set `number'. Because `number' is -1 (lower to 0), an error is reported and the placeholder is skipped. $ i3status -c ./config i3status: trying to auto-detect output_format setting i3status: auto-detected "term" provided CPU number '-1' above detected number of CPU 4 cpu0= cpu1=-48% cpu= provided CPU number '-1' above detected number of CPU 4 cpu0= cpu1=11% cpu= provided CPU number '-1' above detected number of CPU 4 cpu0= cpu1=03% cpu= ...
2018-10-19Merge pull request #315 from gportay/fix-typo-in-manOrestis1-1/+1
man: fix typo for max_threshold in load
2018-10-18man: fix typo for max_threshold in loadGaël PORTAY1-1/+1
Floating values use a dot (not a comma). Fixes: invalid floating point value for option 'max_threshold'
2018-10-11Provide a more natural volume percentage with ALSA.arcnmx1-7/+28
The rationale of the code is explained in the header: http://git.alsa-project.org/?p=alsa-utils.git;a=blob;f=alsamixer/volume_mapping.c;h=1c0d7c45e6686239464e1b0bbc8983ea57f3914f;hb=HEAD > The mapping is designed so that the position in the interval is > proportional to the volume as a human ear would perceive it (i.e., the > position is the cubic root of the linear sample multiplication > factor). and the commit message: http://git.alsa-project.org/?p=alsa-utils.git;a=commit;h=34bb514b5fd1d6f91ba9a7b3a70b0ea0c6014250 > use a mapping where the bar height is proportional to the audible > volume, i.e., where the amplitude is the cube of the bar height. and further explanation can be found in the pull request: https://github.com/i3/i3status/pull/268#pullrequestreview-147429763
2018-10-07strncpy + strlen is pointless (#312)Orestis1-3/+4
strlen already assumes that the string is NULL-terminated. Fixes -Wstringop-overflow warning
2018-09-04Merge pull request #305 from David96/masterIngo Bürk4-1/+13
Add support for "POWER_SUPPLY_STATUS=Not charging" (fixes #304)
2018-09-03Add testcase for #304David963-0/+12
2018-09-03Add support for "POWER_SUPPLY_STATUS=Not charging" (fixes #304)David961-1/+1
2018-08-27Merge pull request #302 from coderonline/masterIngo Bürk1-4/+11
Added %interface to the ethernet options
2018-08-24Added %interface to the ethernet optionsMax Christian Pohle1-4/+11
2018-08-01Merge pull request #301 from wmarvel/issue300Ingo Bürk5-1/+57
Fix for issue 300: Correctly print usage for cpu 10
2018-07-31Fix for issue 300: Correctly print usage for cpu 10=5-1/+57
2018-07-16Merge pull request #296 from Stunkymonkey/include-orderIngo Bürk6-82/+89
switch to clang 3.8 & ignore include sort order
2018-07-16Merge pull request #299 from tuxillo/patch-2Ingo Bürk2-6/+28
Detect interface type on DragonFly BSD
2018-07-15Detect interface type on DragonFly BSDAntonio Huete Jimenez2-6/+28
2018-07-15Merge pull request #298 from tuxillo/patch-1Ingo Bürk2-1/+6
Do not use pulseaudio for DragonFly BSD
2018-07-14Do not use pulseaudio for DragonFly BSDAntonio Huete Jimenez2-1/+6
2018-07-13clang-format-3.8 fix travis errorFelix Buehler1-1/+2
2018-07-13Merge pull request #297 from Stunkymonkey/percent-firstIngo Bürk13-88/+89
able to print percentage
2018-07-13fix clang errorsFelix Buehler3-79/+84
2018-07-13able to print percentageFelix Buehler13-88/+89
its now possible to have percentage before and after a variable. except for the date. But percentage with dates does not make much sense to me, so i skipped it.
2018-07-13Merge pull request #256 from oyvinht/masterIngo Bürk1-9/+56
Read multiple batteries on DragonFly BSD.
2018-07-13Merge pull request #295 from Stunkymonkey/fix-min_width-docsIngo Bürk1-2/+2
fix min_width doc
2018-07-08switch to clang 3.8 & ignore sort oder of includesFelix Buehler2-2/+3
2018-07-07fix min_width docFelix Buehler1-2/+2
2018-06-30Merge pull request #294 from Stunkymonkey/remove_memory_discussionIngo Bürk1-20/+6
forgot to remove memory discussion from man page (it is implemented)
2018-06-30forgot to remove memory discussion from man page (it is implemented)Felix Buehler1-20/+6
2018-06-29Merge pull request #292 from Stunkymonkey/format_qualityIngo Bürk4-5/+9
add format_quality option in wireless
2018-06-29add format_quality option in wirelessFelix Buehler4-5/+9
2018-06-29Merge pull request #293 from Stunkymonkey/hide_seconds_batteryIngo Bürk7-5/+21
hide seconds in battery by default
2018-06-29Merge pull request #291 from duskCoder/cap_net_adminIngo Bürk5-9/+2
Stop requiring CAP_NET_ADMIN
2018-06-29hide seconds in battery by defaultFelix Buehler7-5/+21
2018-06-25Stop requiring CAP_NET_ADMINOlivier Gayot5-9/+2
Since the following commit in the Linux kernel tree 0fdc100bdc4b ethtool: allow non-netadmin to query settings it is no longer necessary to have the CAP_NET_ADMIN capability to query a device speed using ioctl(..., SIOCETHTOOL) in conjonction with the ETHTOOL_GSET ethtool command. The mentioned commit landed first in the 2.6.37 version of the Kernel. This version is no longer maintained nowdays. Since it is not necessary anymore, it is strongly prefered from a security standpoint to drop the CAP_NET_ADMIN capability from the binary. Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>
2018-06-22Merge pull request #290 from duskCoder/changesIngo Bürk9-14/+15
Fix potential issues & avoid unnecessary instructions
2018-06-20Prevent potential crash if glob() failsOlivier Gayot1-1/+1
Calling globfree(NULL) is undefined behaviour. In Linux (glibc), it results in a segmentation fault. It is also undefined behaviour to call globfree(&pglob) if a previous call to glob(&pglob) returned an error. Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>
2018-06-20Fix potential memory leak on LinuxOlivier Gayot1-1/+4
The function slurp_all_batteries(), on Linux, allocates memory dynamically Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>
2018-06-20Fix invalid handling of glob() errors on LinuxOlivier Gayot2-2/+2
The manual of glob(3) says that the function returns 0 on successful completion. Any other integer value should be considered an error, not only negative integers. In practice, *BSD systems use negative values but Linux uses positive integers. Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>
2018-06-20Fix use of undefined macro __OpenBSD__Olivier Gayot1-1/+1
Compiling on Linux with -Wundef produces the following warning: warning: "__OpenBSD__" is not defined, evaluates to 0 [-Wundef] Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>
2018-06-20Avoid assigning a new value to a var before using the old valueOlivier Gayot1-2/+1
Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>
2018-06-20Make sure the arguments passed to printf/die(...) match the formatOlivier Gayot3-4/+5
Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>
2018-06-20No longer use a temporary buffer in the die() functionOlivier Gayot1-3/+1
Before the following change f947d0a Breaks configfiles! Major refactoring of i3status, see below The die(fmt, ...) function was outputting the reason to the status bar in addition to stderr. For this reason, it was meaningful to create a temporary string according to the format string and then passing it around to the different functions. Nowadays, we only display the error message to stderr so calling fprintf(stderr, ...) is much simpler. Signed-off-by: Olivier Gayot <olivier.gayot@sigexec.com>
2018-06-20Merge pull request #289 from bebehei/testsuiteIngo Bürk3-4/+17
Testsuite
2018-06-19Show differing results, if testcase failsBenedikt Heine1-0/+2
2018-06-19Run all travis tests and expose the final result as exit codeBenedikt Heine1-3/+5
2018-06-19Expose the testsuite in the MakefileBenedikt Heine2-1/+4
2018-06-19Fail the tests, if i3status actually crashesBenedikt Heine1-0/+6
2018-06-16Merge pull request #287 from eplanet/emeric/man_typoIngo Bürk1-1/+1
Fix man typo
2018-06-14Fix man typoeplanet1-1/+1